Commit Graph
597 Commits
Author SHA1 Message Date
Maksim Eltyshev 0fab6075bd ref: Refactoring 2023-10-19 16:05:34 +02:00
Lorenz Brun 9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev ec9194dac7 chore: Update chart version 2023-10-18 23:33:30 +02:00
Maksim Eltyshev 2a24fc5155 chore: Update version 2023-10-18 23:20:30 +02:00
Maksim Eltyshev 1ef736106c fix: Fix order of checks when logging in 2023-10-18 23:07:57 +02:00
Maksim Eltyshev 9ea3e1ab0d Merge branch 'master' of github.com:gorrilla10101/planka 2023-10-17 22:31:16 +02:00
Maksim Eltyshev ab9a0e91e2 chore: Update version 2023-10-17 19:31:21 +02:00
Maksim Eltyshev afe83d2760 chore: Bump sails version 2023-10-17 19:23:09 +02:00
Maksim Eltyshev b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Daniel Hiller c21e9cb60a CI: Add prebuild planka package on release 2023-09-30 01:59:09 +02:00
Daniel Hiller 9e2ae17dc0 Meta: Add missing return 2023-09-23 03:48:32 +02:00
Daniel Hiller 909a2ad41a Meta: Add Automated installation 2023-09-23 03:47:46 +02:00
gorrilla10101 dd91d2b9d4 Merge branch 'plankanban:master' into master 2023-09-16 22:15:54 -05:00
Jeffrey cfd85721a3 dynamic environment variables 2023-09-16 21:37:12 -05:00
Daniel Hiller 1dc8560618 chore: fix docker dev build 2023-09-14 01:27:29 +02:00
Daniel Hiller 21dedd00e0 chore: fix runs-on name 2023-09-13 22:55:09 +02:00
Daniel Hiller ca42b5cb77 chore: Switch to self hostet action runner 2023-09-13 22:47:08 +02:00
Daniel Hiller 88b058ad9d chore: Add dev container, based on latest commit 2023-09-13 22:39:37 +02:00
Daniel Hiller ff3cb6a1c8 chore: Switch to pnpm package manager 2023-09-13 22:38:37 +02:00
Maksim Eltyshev 6aefccf543 fix: Fix starting without OIDC environment variables
Closes #503
2023-09-12 01:20:21 +02:00
Maksim Eltyshev e59535b9b4 feat: Use environment variables for default admin configuration 2023-09-12 01:12:38 +02:00
Gilberto Vidal 2dfa79801f fix: Fix Turkish translation linting (#504) 2023-09-11 22:21:46 +05:00
gorrilla10101 6941500c7b feat: OIDC with PKCE flow (#491) 2023-09-04 20:06:59 +05:00
creador30 e254443272 feat: Add Turkish translation (#501) 2023-09-04 19:41:11 +05:00
RocketProto beaa471aca fix: Decouple BASE_URL from Ingress host (#498)
Closes #496
2023-08-27 02:26:45 +05:00
Andrey d91b047be4 fix: Update Russian translation (#497) 2023-08-22 14:34:45 +05:00
Maksim Eltyshev ae14f97592 fix: Fix Czech translation linting
Closes #487
2023-07-31 11:54:50 +02:00
leroyloren c4cc715443 fix: Update Czech translation (#485) 2023-07-27 04:07:47 +05:00
[object Object] 1bd0c2b2c1 feat: Add edit icon to project name (#457) 2023-07-09 20:49:08 +05:00
Maksim Eltyshev a8ea31c9d5 ref: Little refactoring 2023-06-13 12:06:28 +02:00
Maksim Eltyshev ff7fae8de5 fix: Keep task edits when textarea loses focus 2023-06-13 12:04:49 +02:00
[object Object] 60bf1af4f7 fix: Keep comment edits when textarea loses focus (#443)
Closes #441
2023-06-13 14:49:54 +05:00
Maksim Eltyshev 974f7047e4 chore: Update chart version 2023-06-13 00:46:17 +02:00
Maksim Eltyshev 8ca1dda1f7 chore: Update version 2023-06-13 00:25:40 +02:00
Maksim Eltyshev 21504c06a6 fix: Use creation timestamp instead of id for ordering
Closes #465
2023-06-13 00:19:17 +02:00
Maksim Eltyshev 8578883fac fix: Fix saving milliseconds for timestamps 2023-06-12 23:54:57 +02:00
ULiiAn a6cfad4d35 fix: Fix Chinese translation (#464)
Closes #463
2023-06-12 14:51:31 +05:00
Christopher Greaves 3487bb8964 feat: Add official Helm Chart (#442)
Closes #192
2023-05-25 20:23:11 +05:00
orbatschow 18e231fcaa feat: Allow postgres connections that require ssl mode (#409)
Closes #261
2023-03-06 17:54:52 +05:00
Zsh 2c66d53a08 fix: Update Chinese translation (#410) 2023-03-06 17:12:59 +05:00
LuisLiu ec638bb072 feat: Add Chinese translation (#398) 2023-03-06 17:07:00 +05:00
Maksim Eltyshev 7f92deca85 chore: Update version 2023-02-27 22:57:52 +01:00
Maksim Eltyshev e93cc88f5c revert: Allow postgres connections that require ssl mode (#408)
This reverts commit d627a5660a.
2023-02-28 02:56:16 +05:00
Maksim Eltyshev 0eeb10a4b0 chore: Update version 2023-02-27 19:12:59 +01:00
Maksim Eltyshev 22ec8707ac fix: Rename timer to stopwatch
Closes #392
2023-02-27 19:09:51 +01:00
orbatschow d627a5660a feat: Allow postgres connections that require ssl mode (#404)
Closes #261
2023-02-27 21:16:51 +05:00
Maksim Eltyshev becf4afe85 fix: Prevent board from scrolling when it starts with non-left-click 2023-02-25 15:09:46 +01:00
Maksim Eltyshev 2bc6dd94f5 docs: Add installation link for windows 2023-02-23 16:40:16 +01:00
Maksim Eltyshev 9c241acff8 fix: Fix paths in css files when building on windows 2023-02-22 19:59:40 +01:00
Maksim Eltyshev f9d191ecc8 docs: Update information, links to documentation 2023-02-20 23:36:52 +01:00