feat: Improve mime type detection, limit image processing size

server/api/helpers/attachments/process-uploaded-file.js

@@ -5,12 +5,12 @@
 
 const fsPromises = require('fs').promises;
 const { rimraf } = require('rimraf');
+const { fileTypeFromFile } = require('file-type');
 const { getEncoding } = require('istextorbinary');
-const mime = require('mime');
 const sharp = require('sharp');
 
 const filenamify = require('../../../utils/filenamify');
-const { MAX_SIZE_TO_GET_ENCODING } = require('../../../constants');
+const { MAX_SIZE_TO_GET_ENCODING, MAX_SIZE_TO_PROCESS_AS_IMAGE } = require('../../../constants');
 
 module.exports = {
   inputs: {
@@ -24,7 +24,8 @@ module.exports = {
     const fileManager = sails.hooks['file-manager'].getInstance();
 
     const filename = filenamify(inputs.file.filename);
-    const mimeType = mime.getType(filename);
+    const fileType = await fileTypeFromFile(inputs.file.fd);
+    const { mime: mimeType = null } = fileType || {};
     const { size } = inputs.file;
 
     const { id: uploadedFileId } = await UploadedFile.qm.createOne({
@@ -65,7 +66,7 @@ module.exports = {
       image: null,
     };
 
-    if (!['image/svg+xml', 'application/pdf'].includes(mimeType)) {
+    if (mimeType && mimeType.startsWith('image/') && size <= MAX_SIZE_TO_PROCESS_AS_IMAGE) {
       let image = sharp(buffer || filePath || inputs.file.fd, {
         animated: true,
       });