ref: Refactoring

server/api/helpers/lists/create-one.js

@@ -25,7 +25,7 @@ module.exports = {
   async fn(inputs) {
     const { values } = inputs;
 
-    const lists = await sails.helpers.boards.getFiniteListsById(values.board.id);
+    const lists = await sails.helpers.boards.getKanbanListsById(values.board.id);
 
     const { position, repositions } = sails.helpers.utils.insertToPositionables(
       values.position,

server/api/helpers/lists/is-kanban.js

@@ -3,7 +3,6 @@
  * Licensed under the Fair Use License: https://github.com/plankanban/planka/blob/master/LICENSE.md
  */
 
-// TODO: rename?
 module.exports = {
   sync: true,
 
@@ -15,6 +14,6 @@ module.exports = {
   },
 
   fn(inputs) {
-    return inputs.record.name || _.upperFirst(inputs.record.type);
+    return List.KANBAN_TYPES.includes(inputs.record.type);
   },
 };

server/api/helpers/lists/resolve-name.js

@@ -0,0 +1,27 @@
+/*!
+ * Copyright (c) 2024 PLANKA Software GmbH
+ * Licensed under the Fair Use License: https://github.com/plankanban/planka/blob/master/LICENSE.md
+ */
+
+module.exports = {
+  sync: true,
+
+  inputs: {
+    record: {
+      type: 'ref',
+      required: true,
+    },
+    t: {
+      type: 'ref',
+    },
+  },
+
+  fn(inputs) {
+    if (inputs.record.name) {
+      return inputs.record.name;
+    }
+
+    const name = _.upperFirst(inputs.record.type);
+    return inputs.t ? inputs.t(name) : name;
+  },
+};

server/api/helpers/lists/update-one.js

@@ -58,7 +58,7 @@ module.exports = {
     const board = values.board || inputs.board;
 
     if (!_.isUndefined(values.position)) {
-      const lists = await sails.helpers.boards.getFiniteListsById(board.id, inputs.record.id);
+      const lists = await sails.helpers.boards.getKanbanListsById(board.id, inputs.record.id);
 
       const { position, repositions } = sails.helpers.utils.insertToPositionables(
         values.position,